Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for rails 7.2 #65

Closed
wants to merge 14 commits into from
Closed

Add support for rails 7.2 #65

wants to merge 14 commits into from

Conversation

ltickett
Copy link 

$ bundle install
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Could not find compatible versions
Because db-query-matchers >= 0.12.0 depends on activesupport >= 4.0, < 7.2
  and rails >= 7.2.0 depends on activesupport = 7.2.0,
  db-query-matchers >= 0.12.0 is incompatible with rails >= 7.2.0.
So, because Gemfile depends on rails ~> 7.2.0
  and Gemfile depends on db-query-matchers ~> 0.12.0,
  version solving has failed.

@ltickett
Copy link
Author

@sds could you take a look please?

I had to remove rails7.1 as it seems to be causing issues (looks like the latest main is seeing the same issue).

TIA

@ngrebenshikov
Copy link
Contributor

I haven't seen your pull request. Sorry! Created another one - #66. But it solves the Rails 7.1 issue. It can be copied to yours.

Dear maintainers, could you, please, take a look at our pull requests and release a gem with the Rails 7.2 support 🙏.

@sds sds closed this Aug 14, 2024
@ltickett
Copy link
Author

No problem @ngrebenshikov as long as it's fixed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ltickett @ngrebenshikov @sds